[Webkit-unassigned] [Bug 14815] [gtk] API implementation: reload

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14815





------- Comment #4 from xan.lopez at gmail.com  2007-07-30 13:06 PDT -------
(In reply to comment #2)
> Looks good two minor things:
>    -As of yesterday we have decided to use the WebKit CodingStyle in the
> WebKit/Gtk API implementation. E.g use camelCase for variable names. This makes
> private_data -> privateData and frame_data -> frameData and we need to do that
> for the rest of the implementation as well (but in another patch)

ACK.

> 
>    -Did you use WebKitTools/Scripts/prepare-ChangeLog to create the ChangeLog
> entry?

Nope, is it mandatory as long as the output is OK?

> +webkit_gtk_page_reload (WebKitGtkPage *page); it should be WebKitGtkPage* page
> in both the header and the implementation. In theory the header could be
> different but currently all other methods use WebKitGtkPage*, we can decide to
> change that for the header but this would need to be handled in a different
> bug.

Ok, GTK+ uses the type *foo style, but I have no strong feelings about it. The
only real benefit I can see is more clarity when declaring more than one
variable in one line.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.