[Webkit-unassigned] [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14745





------- Comment #10 from nigel.tao.gnome at gmail.com  2007-07-30 05:57 PDT -------
On second thoughts, I think that the better place to fix this (the --gdk flag
being passed to GdkLauncher and subsequently interpreted as a URL) is in
WebKitTools/GdkLauncher/main.cpp rather than in
WebKitTools/Scripts/run-launcher.  You could patch run-launcher to explicitly
scrub the --gdk argument, but you would miss any other flags that run-launcher
takes (or could take, in the future), and GdkLauncher would (incorrectly) try
to interpret them as a URL.

The patch would look something like:
------------------------------------------------------
--- WebKitTools/GdkLauncher/main.cpp    (revision 24771)
+++ WebKitTools/GdkLauncher/main.cpp    (working copy)
@@ -119,7 +119,7 @@
             dumpRenderTree = true;
         else if (stringIsEqual(currArg, "-dumprendertree"))
             dumpRenderTree = true;
-        else
+        else if (currArg[0] != '-')  // currArg looks like an (unknown) -flag,
not a URL
             url = autocorrectURL(currArg);
     }
------------------------------------------------------

If you agree that this is the right approach, then I'll prepare a proper
ChangeLog entry etc.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.