[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14740





------- Comment #2 from aroben at apple.com  2007-07-28 22:55 PDT -------
(From update of attachment 15723)
This looks like a great start! A few comments:

+my $platform;

I think it would be good to define $platform to its default setting before
parsing the options. Then you can show the default in the usage output.

+my $platformTestDirectory = $testDirectory . "/platform/";

It would be nice to use File::Spec->catdir() instead of building up these paths
manually.

+} elsif (isTiger()) {
+    $platformTestDirectory .= "mac-leopard";
+} elsif (isLeopard()) {
+    $platformTestDirectory .= "mac";

I think these are reversed.

+    foreach my $level (@platformHierarchy) {
+        return $level if (-f "$level/$base-$expectedTag.txt");
+    }

I believe this will traverse the platform hierarchy from least- to
most-specific, but we want it to go the other way, so that results in, for
example, `mac-leopard` will override results in `mac`


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.