[Webkit-unassigned] [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 26 09:40:35 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=14745
ddkilzer at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15690|review? |review-
Flag| |
------- Comment #8 from ddkilzer at webkit.org 2007-07-26 09:40 PDT -------
(From update of attachment 15690)
Looks great! I'm going to give it an r- since I'd like to see a ChangeLog
entry, and I have one minor quibble below.
>+ # Strip --gdk from the arg-list, since otherwise GdkLauncher will try to
>+ # interpret it as a URL.
>+ @args = grep(!/^(--gdk)$/, @ARGV);
Please use @args instead of @ARGV here. If someone changes the script later to
process @args differently above, then this code won't pick up those changes.
Thanks!
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list