[Webkit-unassigned] [Bug 14711] RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 06:15:38 PDT 2007


nigel.tao.gnome at gmail.com changed:

           What    |Removed                     |Added
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

------- Comment #9 from nigel.tao.gnome at gmail.com  2007-07-26 06:15 PDT -------
It looks like Alp Toker's patch has landed in trunk, but the pushbuttons'
backgrounds are still being (incorrectly) filled in.  You can see the problem
in the screenshot at

You might want to apply this part of my patch:

Index: WebCore/platform/gdk/RenderThemeGdk.cpp
--- WebCore/platform/gdk/RenderThemeGdk.cpp     (revision 24641)
+++ WebCore/platform/gdk/RenderThemeGdk.cpp     (working copy)
@@ -288,7 +288,13 @@
     if (!m_container) {
         m_unmappedWindow = gtk_window_new(GTK_WINDOW_POPUP);
-        m_container = gtk_fixed_new();
+        // Some GTK themes (i.e. Clearlooks) draw the buttons differently
+        // (in particular, call gtk_style_apply_default_background) if they
+        // are unallocated and are children of a GtkFixed widget, which is
+        // apparently what some "make Firefox buttons look like GTK" code
+        // does.  To avoid this ugly look, we use a GtkHBox as a parent,
+        // rather than a GtkFixed.
+        m_container = gtk_hbox_new(false, 0);
         gtk_container_add(GTK_CONTAINER(m_unmappedWindow), m_container);

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list