[Webkit-unassigned] [Bug 14757] HTMLTokenizer::processingData implementation is incorrect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 25 20:05:11 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=14757
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15688|review? |review-
Flag| |
------- Comment #10 from darin at apple.com 2007-07-25 20:05 PDT -------
(From update of attachment 15688)
(In reply to comment #3)
> However, it seems to me that a new test is unnecessary, since processingData()
> should obviously return true if HTMLTokenizer is still inside the write()
> function.
Sorry, I think there's a misunderstanding here.
A new test is necessary. Proving that the fix is correct is only one reason to
add a test. The more important reason for a test is to prevent the bug from
being reintroduced later on.
We definitely need to add a test for this unless it's impractical. The patch
should include that test.
+ //return m_timer.isActive();
We don't check in commented-out code.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list