[Webkit-unassigned] [Bug 14761] New: Web Inspector Leak

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14761

           Summary: Web Inspector Leak
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: john at johnmoe.com


Open any page, right click Inspect Element, close both windows.  Lots of items
will not be garbage collected (heap.numLiveObjects will be large).  You can
repeat and the number will continue to grow.


InspectorController::m_scriptObject is never unprotected, because the call to
JSObjectSetPrivate() in the InspectorController destructor causes unloading()
to never call windowUnloading(). 


A Fix:
In InspectorController.cpp, InspectorController destructor, move:
    m_client->inspectorDestroyed();

before:
    if (m_scriptContext) {

and remove:
    m_client->closeWindow();

It seems to fix the leak and things seem to still work, but I've been playing
with the WebKit code for less than a day, so who knows?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.