[Webkit-unassigned] [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14745


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15660|                            |review-
               Flag|                            |




------- Comment #2 from ddkilzer at webkit.org  2007-07-24 07:45 PDT -------
(From update of attachment 15660)
Thanks for the patch, Nigel!  In the future, please set the "review?" flag on
patches to make sure they're reviewed in a timely manner.

>-  $launcherPath = "$launcherPath/WebKitTools/GdkLauncher";
>+  $launcherPath = "$launcherPath/WebKitTools/GdkLauncher/GdkLauncher";

This looks correct.

>+        else if (currArg[0] == '-')  // currArg looks like an (unknown) -flag, not a URL
>+            ;  // No-op.  We'll just silently ignore unknown flags

This looks like a different bug?  Why is this change needed?

However, this patch is missing a ChangeLog entry.  See this page for details on
how to create one using the prepare-ChangeLog script:

http://webkit.org/coding/contributing.html

Setting review- flag for no ChangeLog and unknown change to main.cpp.  Please
make these fixes and repost the patch.  Thanks!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.