[Webkit-unassigned] [Bug 14678] [gdk] API Drafting

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14678





------- Comment #8 from aroben at apple.com  2007-07-22 13:24 PDT -------
(In reply to comment #7)
> (From update of attachment 15624 [edit])
> +    WebKitGtkFrame* gtkFrame() const { return m_gtkFrame; }
> 
> You shouldn't be holding onto WebKit types inside WebCore.  On Windows we get
> back to the WebFrame* through the FrameLoaderClient* pointer (a little ugly,
> but it keeps the separation).

I was a little unclear here. On Windows, WebFrame is the class that implements
WebCore::FrameLoaderClient, so we just static_cast the FrameLoaderClient* to a
WebFrame*, because we know within WebKit that that's what it is. Since you have
a separate FrameLoaderClientGdk class, I guess that's where the WebKitGtkFrame*
pointer should go.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.