[Webkit-unassigned] [Bug 14711] RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14711





------- Comment #2 from aroben at apple.com  2007-07-22 12:11 PDT -------
(From update of attachment 15618)
+    GtkStateType state_type = isHovered(o)
+        ? (isPressed(o) ? GTK_STATE_ACTIVE : GTK_STATE_PRELIGHT)
+        : GTK_STATE_NORMAL;

I think this line would be clearer as:

GtkStateType state_type = isPressed(o) ? GTK_STATE_ACTIVE : (isHovered(o) ?
GTK_STATE_PRELIGHT : GTK_STATE_NORMAL);

...or...

GtkStateType state_type = GTK_STATE_NORMAL;
if (isPressed(o))
    state_type = GTK_STATE_ACTIVE;
else if (isHovered(o))
    state_type = GTK_STATE_PRELIGHT;

I personally prefer the second one.

Also, the variable name sould be `stateType` to adhere to our style guidelines
<http://webkit.org/coding/coding-style.html>


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.