[Webkit-unassigned] [Bug 6129] Incomplete implementation of CSS 2.1 system colors

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=6129


rwlbuis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15614|                            |review?
               Flag|                            |




------- Comment #7 from rwlbuis at gmail.com  2007-07-21 12:55 PDT -------
Created an attachment (id=15614)
 --> (http://bugs.webkit.org/attachment.cgi?id=15614&action=view)
First attempt

This patch uses the same code basically as Mozilla codebase, old carbon calls.
Not surprisingly that it matches FF2 with this test:

http://bugs.webkit.org/attachment.cgi?id=5128&action=view

There are some things to clear up:

- is it ok to use the old Carbon calls? I guess NSColor could workI guess but
it needs more lines.
- already since the patch changes ButtonFace value on my system so a lot of
regressions are there in the  non-pixel tests, so a lot of tests would need to
be updated.
- would we get system color dependent test results after this patch? How to do
an added testcase if it would depend on the system the test runs on? I am not
sure how much the system colors can be changed by the average user, but at
least highlight color can be changed.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.