[Webkit-unassigned] [Bug 14626] Make bidiReorderCharacters independent of RenderBlock

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14626


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15546|0                           |1
        is obsolete|                            |
  Attachment #15562|                            |review?
               Flag|                            |




------- Comment #8 from mitz at webkit.org  2007-07-18 10:14 PDT -------
Created an attachment (id=15562)
 --> (http://bugs.webkit.org/attachment.cgi?id=15562&action=view)
Take bidiReorderCharacters out of RenderBlock

This is more or less what I would like to do as a first (and biggest) step.
After this separation of the render-tree case and the character buffer case is
done, I think you could add bidi-aware string drawing functionality to the
graphics layer (and expose it as WebKit SPI as necessary), and -- quite
independently -- continue cleaning up bidi.cpp (getting rid of the remaining
file statics).

No layout test regressions.

In terms of performance, I used both attachment 15549 and a PLT suite
consisting of all fast/text tests save one, and I have reached a point where
the numbers are better than TOT, and any further tweaking that I do does not
change the numbers significantly.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.