[Webkit-unassigned] [Bug 14655] New: Semantic of the setters of ResourceResponse in regard to m_isNull

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14655

           Summary: Semantic of the setters of ResourceResponse in regard to
                    m_isNull
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: freyther at handhelds.org


In #14059 I introduced a couple of new setters this was fine as the
ResourceResponse was already mutable. The only weakpoint was that these setters
are the only ones setting m_isNull to false (which was needed for the curl
backend to function).

E.g.
ResourceResponse resp;
resp.setModificationTime(70);
ASSERT(!resp.isNull()); <- will abort as resp.isNull() will return true

ResourceResponse resp;
resp.setTextEncoding("utf-8");
ASSERT(!resp.isNull()); <- wiill work as the new setTextEncoding will set
m_isNull to false.


The question to be made is to either:
a) make all setters set m_isNull to false
b) decide which setters will reset m_isNull
c) updateResponse will reset m_isNull when enough information is there
d) add a setIsNull(bool) or better named method.

It would be nice to know the preferred approach and I will prepare a patch.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.