[Webkit-unassigned] [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 10:37:07 PDT 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #15544|review?                     |review+
               Flag|                            |

------- Comment #17 from darin at apple.com  2007-07-17 10:37 PDT -------
(From update of attachment 15544)
Some nice improvements.


I still don't understand why you need to check for "inf". Wouldn't a check for
"i" be good enough?

No need for else after return and you could probably simplify the logic and
just have one return NaN.

+            number = parseIntOverflow(s.substr(firstDigitPosition).ascii(), p
- firstDigitPosition, radix);

Could use substr(firstDigitPosition, p - firstDigitPosition) here -- more
consistent with the expression above.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list