[Webkit-unassigned] [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=9697


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15541|review?                     |review+
               Flag|                            |




------- Comment #15 from darin at apple.com  2007-07-17 08:18 PDT -------
(From update of attachment 15541)
r=me

+    const char* p;
+    int digit;

I would have declared these where they are used rather than at the top of the
function.

+            number = parseIntOverflow(s.substr(firstDigitPosition).ascii(), p
- firstDigitPosition, radix);

Could pass p - firstDigitPosition to substr too to make a smaller buffer.

+          if (strncasecmp(c, "inf", 3) == 0)

This could use a comment like the one you wrote in this bug -- we shouldn't
leave something unclear and non-obvious like this behind for the future.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.