[Webkit-unassigned] [Bug 14059] [CURL] Does not call didReceiveResponse()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 01:49:35 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14059





------- Comment #15 from freyther at handhelds.org  2007-07-17 01:49 PDT -------
(In reply to comment #14)
> (From update of attachment 15477 [edit])
> Instead of adding all those setters to ResourceResponse, I think you should use
> the constructor that takes all of the values as parameters.
> 
>     d->m_response = ResourceResponse(x, x, x, x, x);
> 
> I suppose there's no major harm in adding the setters, but there's no major
> benefit either.

Well, in this case I should have a HTTPHeaderMap in my ResourceHandleInternal
as well and either add a setHTTPHeaderMap to ResourceResponse (like in a
previous version of this patch), but if you compare the two versions I think
the current one (requring more setters) is better to read.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list