[Webkit-unassigned] [Bug 14609] gdk painting changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 15:50:20 PDT 2007


zimmermann at kde.org changed:

           What    |Removed                     |Added
  Attachment #15502|review?                     |review+
               Flag|                            |

------- Comment #2 from zimmermann at kde.org  2007-07-15 15:50 PDT -------
(From update of attachment 15502)
 Hi Holger,

even though I'm not a gdk/gtk expert this looks like a nice patch.

I'm not sure wheter you are adhering to the style guide in the gdk port, if
yes, tiny remark:

+struct FrameGdkExposeData{
+    GtkContainer *container;
+    GdkEventExpose *expose;

missing space after {, stars should be moved.

+static void
+frame_gdk_expose_child(GtkWidget *widget, gpointer _data)

Don't use two lines here.
Other than style remarks, all fine, r=me.


Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list