[Webkit-unassigned] [Bug 13212] Submit initial version of WebKit Apollo bitmap interface for feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 11:23:14 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13212





------- Comment #3 from bdash at webkit.org  2007-07-15 11:23 PDT -------
(From update of attachment 13838)
About the directory naming:  I'm not sure what having the extra level
"WebKitApollo" adds to things.  On the Mac at least the
<WebKitApollo/HeaderName.h> framework-style references would work for free due
to how Xcode's header copying build phase works.  You may want to take a look
at how we handle the Windows WebKit layer accessing WebCore headers using the
<WebCore/HeaderName.h> style import and use a similar approach here.

Miscellaneous coding style points:
*) There is a lot of extraneous whitespace inside parentheses in your
typedef's.
*) The *-placement inside your typedefs isn't consistent.
*) The name m_pVTable in WebKitApolloBitmap seems like it's bordering on
Hungarian notation.

What is the purpose of the WEBKIT_APOLLO_PROTO1 and WEBKIT_APOLLO_PROTO2
macros?  Their names provide no information as to the reason for their
existence, and their empty definitions are not particularly enlightening
either.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list