[Webkit-unassigned] [Bug 13517] DOM Exception 8 in finance.aol.com sub-page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 14 10:09:19 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13517


bdash at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #11 from bdash at webkit.org  2007-07-14 10:09 PDT -------
Landed in r24287.

I had to tweak the ChangeLog a bit as they were missing some useful
information.  The LayoutTests one was missing half the files that had been
touched, and neither had much information about what exactly was being fixed. 
It's usually a good idea to include a simple description of the bug being fixed
(the Bugzilla title may suffice in some instances), and a brief comment of how
the patch fixes it.  Have a quick skim through JavaScriptCore/ChangeLog and
WebCore/ChangeLog to get a feel for this.  Another minor nit was that a tab
character snuck into nodes.cpp in your patch -- not a big deal as a pre-commit
hook catches them, but it's worth keeping in mind.

Thanks for the patch!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list