[Webkit-unassigned] [Bug 14054] REGRESSION: cupid.com uses iframe.document to make content visible

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14054





------- Comment #5 from ddkilzer at webkit.org  2007-07-13 14:45 PDT -------
(In reply to comment #4)
> if (userAgent.indexOf('applewebkit/522+') != -1 ||
> userAgent.indexOf('opera/9.10') != -1) 

Please consider using "object detection" instead of user agent sniffing here:

if (document.getElementById("iframe").ownerDocument)

For more info about this technique see:

http://developer.apple.com/internet/webcontent/objectdetection.html

> {
>    var the_height= document.getElementById("iframe").ownerDocument.body.offsetHeight;
>    //change the height of the iframe
>    document.getElementById("iframe").height = (the_height);
>    document.getElementById("mainBody").height = (the_height + 50);
> }       

I think you may want to use ".style.height" instead of simply ".height" here. 
Does that make any difference in rendering?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.