[Webkit-unassigned] [Bug 13517] DOM Exception 8 in finance.aol.com sub-page

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13517


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15495|review?                     |
               Flag|                            |
  Attachment #15495|0                           |1
        is obsolete|                            |
  Attachment #15499|                            |review?
               Flag|                            |




------- Comment #6 from cwzwarich at uwaterloo.ca  2007-07-13 03:56 PDT -------
Created an attachment (id=15499)
 --> (http://bugs.webkit.org/attachment.cgi?id=15499&action=view)
Revised proposed patch

Here is a revised version of my patch. It fixes one coding style issue, and a
regression on the test fast/js/const (the build was broken, so I submitted it
only using the old JS tests).

I added test cases for these two bugs. Alexey asked me why I copied the
arguments check that was introduced in the patch for bug 13456 in addition to
the first check, so I added test cases to fast/js/vardecl-preserve-arguments
that would fail if that second check weren't there.

When fast/js/const failed, I fixed it by adding code to apply the ReadOnly
attribute. In the process of doing so, I found a few existing bugs in the
handling of const (that this patch neither introduces nor fixes). In
particular, the following are allowed:

var x = 1;
const x = 2;

const y = 1;
const y = 2;

There are some more elaborate ones than this, but I will file them all as a
separate bug and include a fix. I simply wanted to mention it here because it
is more apparent after looking at the code in this patch.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.