[Webkit-unassigned] [Bug 14569] Repro crash due to saved state not being cleared when select and textarea elements are adopted by another document

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 10 00:47:49 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14569





------- Comment #2 from beidson at apple.com  2007-07-10 00:47 PDT -------
I'm okay with this patch - but I just had a discussion with mitz on IRC.  I
think now that we have these new cases that have to patch in to the will/did
move document calls that the original patch in 14400 is more appropriate.  It
would be very easy to adapt here.

I look at it this way.  If we land this new patch, we'll be maintaining 3
distinct implementations of the will/did move document calls.  One in TextArea,
one in Select, and one in Input.  However, they are largely duplicates of each
other.

If we go back to Mitz's original patch in 14400, there will be yet another new
call to override in genericform and inputelement, and we'll have to maintain it
in these multiple places, but it will be much more targeted code will be
duplicated.

Mitz said he was starting to lean towards that solution as well, but I'm only
slightly in favor of reverting back to the original 14400 patch  =D


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list