[Webkit-unassigned] [Bug 14453] REGRESSION: www.nzherald.co.nz almost all the formating is gone

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 8 09:27:46 PDT 2007


------- Comment #22 from rwlbuis at gmail.com  2007-07-08 09:27 PDT -------
Hi Darin,

(In reply to comment #21)
> (From update of attachment 15416 [edit])
> It's not portable to call isdigit on a 16-bit character and count on it
> returning false for non-ASCII values. In particular I think it either doesn't
> compile at all or warns on Windows. Instead the code should just compare the
> UChar to check if it's >= '0' and <= '9'. We should probably add some helpful
> ASCII versions of ctype.h functions too, because the ctype.h functions change
> their behavior based on the current locale and we really don't want that. I
> think Sam Weinig is working on that.

Right, not using isdigit anymore in my upcoming patch.

> Sorry to keep nitpicking this, but I still don't think that HASH is a clear
> name for one of two different tokens that both start with "#". My original

I am going for the name HEX for now.

> comment still stands -- every code path for IDSEL and HASH is identical and
> it's not helpful that the lexer gives two different tokens for these two
> different cases. They should be combined into a single token. I think HASH
> *would* be a reasonable name for that single token.

I would like a single token too, the problem I have is that things like \0031
in an id selector get translated to simply '1', at which point I can't
distinguish it from an id sel of #1, which also becomes '1'.
Unfortunately I only see the two labels as a solution for this. I am open for
suggestions though :)


Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list