[Webkit-unassigned] [Bug 12384] getComputedStyle with td.style.display='none' reports '' for all properties except display

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12384


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15442|review?                     |review+
               Flag|                            |




------- Comment #11 from darin at apple.com  2007-07-08 04:58 PDT -------
(From update of attachment 15442)
+    virtual RenderStyle* computedStyle() { return parent() ?
parent()->computedStyle() : 0; }

I don't think it's helpful to define a virtual function like this one as an
inline in the header. It's easier to modify it if it's even needed if you keep
it in the .cpp file instead, and it would only actually get inlined if it was a
non-virtual call, which should never happen in this case.

But that's a nitpick. This looks great!

I guess I was wrong about CSSStyleSelector needing a change!

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.