[Webkit-unassigned] [Bug 14453] REGRESSION: www.nzherald.co.nz almost all the formating is gone

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14453


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15385|review?                     |review-
               Flag|                            |




------- Comment #18 from darin at apple.com  2007-07-05 00:25 PDT -------
(From update of attachment 15385)
This looks good, but not quite right. With this patch, every case in the parser
that allows HEX_OR_IDENT also allows IDSEL, so it doesn't seem good to have two
different tokens for these.

For the "specifier" production we allow characters that start with a numeric
character, as long as they happen to be 3 or 6 hex digits. That doesn't seem
right to me. Is our handling of such selectors consistent with other CSS
parsers?

I think that certain types of illegal colors would still malfunction with our
engine. For example, "#2bogus".

HEX_OR_IDENT is a strange name for a token that is # followed by either 3 or 6
hexadecimal digits. So if we keep it we should probably rename it.

Would you be willing to clean this up a bit more and straighten it out?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.