[Webkit-unassigned] [Bug 14442] Adding a stop with value 1.0 to a gradient that has already been used has no effect

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14442


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15390|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2007-07-05 00:14 PDT -------
(From update of attachment 15390)
Seems like a good idea.

But I don't think this is right yes. I don't think that findStop will return -1
for values that are less than the first stop; we need a test case that covers
that.

Also, I don't think the special cases in CanvasGradient::getColor for <= 0 and
>= 1 will work properly, since they assume that <= 0 and >= 1 are the first and
last stop. In fact, I suspect that was already broken since the sorting is done
inside findStop, and there's no guarantee it's called in those cases.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.