[Webkit-unassigned] [Bug 9508] JavaScript Comparing a form element group to itself returns false.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=9508





------- Comment #13 from sanjay12 at gmail.com  2007-01-31 23:50 PDT -------
I started working on a new patch based on your suggestions. I understood most
of what you said, but one thing I'm not completely clear on is that the
DOMNamedNodesCollection should hold a refptr to the node which created it. How
would I be able to access that in JSHTMLCollection::getNamedItems given that it
can be called either via the nameGetter or from JSHTMLFormElement? In the
latter case, the JSHTMLCollection created is just a temp object. 

And even then, I'm not quite sure why that would be needed to prevent aliasing.
The individual nodes that make up the form element group won't be destroyed
throughout the life of the document, correct? If that's so, and we're hashing
the Node pointer to the first node that makes up the group and the identifier,
then I don't see how it's a problem.

Actually, it just occurred to me if that is the case, then actually we don't
need to hash with the Node pointer to the first node PLUS the identifier. The
identifier actually doesn't matter at the point where you've already grabbed
the named items from that identifier, and are hashing with the node pointer to
the first node in the named element group. Or, if that didn't make sense,
basically the patch that I submitted on the 30th didn't need to hash with a
string at all. It could have hashed just the Node pointer to the first element,
and that would be that.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.