[Webkit-unassigned] [Bug 12488] Paint server in objectBoundingBox mode not ignored if path has an empty bounding box

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12488


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12812|review?                     |review-
               Flag|                            |




------- Comment #4 from macdome at opendarwin.org  2007-01-31 04:16 PDT -------
(From update of attachment 12812)
I think this is OK.  I'm not a huge fan of tying buildEffectiveAttributes()
dependencies into the server resolution.  I think it fit better inside a
setup() call.

Also, I dont' think this is right:

+    if (!strokePaintServer) {
+        // default value (black)
+        strokePaintServer = sharedSolidPaintServer();
+       
static_cast<SVGPaintServerSolid*>(strokePaintServer)->setColor(Color::black);
+    }

that should just be special cased into 
+            if (strokePaintServer->boundingBoxMode() &&
item->relativeBBox(false).isEmpty())
+                strokePaintServer = 0;
instead.

Otherwise I think the patch is OK.

You should definitely have a reference to the spec about the empty bounding
box.

Oh, and I don't think you need to special case this for fill servers.  I don't
see how you could ever end up drawing a fill when there is no bounding box.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.