[Webkit-unassigned] [Bug 12490] New: Clean up canPlaceOnLine logic in bidi.cpp

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12490

           Summary: Clean up canPlaceOnLine logic in bidi.cpp
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: hyatt at apple.com, mitz at webkit.org


The logic for calculating canPlaceOnLine in bidi.cpp may be simplified.  This
is a follow-up to Bug 12423 Comment #21.

A true table for your edification:

                         auto
                         Wrap
                         Was
              will       Ever
              Fit        True
              On   auto  On
[0]  [1]  [2] Line Wrap  Line
---  ---  --- ---- ---- -------
 T    T    T    T    T    T
 T    T    T    T    T    T (F)
 T    T    T    T    F    T     
 T    T    T    T    F    F     
 F    F    F    F    T    T     
 F    F    F    F    T    T (F) 
 T    F    F    F    F    T     
 T    T    T    F    F    F     

[0] bool canFitOnLine = willFitOnLine || !autoWrap;
[1] bool canFitOnLine = willFitOnLine || !autoWrap;
    if (!willFitOnLine && !autoWrap && autoWrapWasEverTrueOnLine) 
        canFitOneLine = false;
[2] bool canFitOnLine = willFitOnLine || !willFitOnLine &&
!autoWrapWasEverTrueOnLine;


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.