[Webkit-unassigned] [Bug 12462] Need -[WebView setAllowsUndo:] API

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12462


bdash at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12766|review+                     |review-
               Flag|                            |




------- Comment #12 from bdash at webkit.org  2007-01-29 18:18 PDT -------
(From update of attachment 12766)
A few comments:
1) you should include the ChangeLog entry as part of the patch rather than as a
separate file.
2) +        if ([decoder containsValueForKey: @"AllowsUndo"])  has extra
whitespace after the colon.
3) 
+    if (! _private->allowsUndo) {
+        return nil;
+    }

has unneeded braces.

If you could address those two minor issues, resubmit your patch and mark it r?
I will take another look and land it.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.