[Webkit-unassigned] [Bug 12423] Mixing white-space:pre text with non white-space:pre text does not wrap properly

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12423





------- Comment #15 from ddkilzer at webkit.org  2007-01-27 21:18 PDT -------
(In reply to comment #14)
> (From update of attachment 12720 [edit])
> This looks suspicious to me.  I'll need to study it some more.

I wouldn't expect anything less from my first ever patch to bidi.cpp.  :)

Note that all layout tests passed with this change.

I started with something like this:

    if (!willFitOnLine && !autoWrap && last && last->isText() &&
last->style()->autoWrap())
        canPlaceOnLine = false;

Then I came up with some more test cases (see Attachment 12719) that required
this concept to be generalized for any text run on the line.  Thus if any text
run on the current line had autoWrap set to true, then this text run shouldn't
be placed on the current line.   Instead, it should wrap.

Of course, I could be missing something since I'm not real familiar with this
code.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.