[Webkit-unassigned] [Bug 11131] Repeated string concatenation results in OOM crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 26 08:03:29 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=11131





------- Comment #8 from ddkilzer at webkit.org  2007-01-26 08:03 PDT -------
(From update of attachment 12680)
NOTE: I am NOT a reviewer...more of a random patch commentator.

>+        } else {
>+            return jsString(value);
>+        }

Unneeded curly braces here and in a few other places.

>+shouldThrow('s = "a"; while (1) { s += s; }', '"Error: Out of memory"');

How "fast" does this actually run, e.g., how long does this test take to run? 
(Hmm...I suppose it would depend on how much memory the system has that it runs
on.)  Perhaps a string longer than one character should be used, though, so it
will run faster.  Maybe 512 or 1024 characters?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list