[Webkit-unassigned] [Bug 12401] New: Avoid unnecessary allocations in CSS

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12401

           Summary: Avoid unnecessary allocations in CSS
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bdakin at apple.com


>From <rdar://problem/4946877>

* SUMMARY
Patch attached which avoids several unnecessary allocations, cutting down on
time in malloc and free.

1. css/MediaQueryEvaluator.cpp, css/MediaQueryEvaluator.h,
css/cssstyleselector.cpp

Add a special method to the MediaQueryEvaluator class to avoid unnecessary
turning a char * into a String object.  

2. loader/Cache.cpp

Don't turn a KURL's underlying String into another identical KURL.  Or, even
better, you could change the prototype to createResource to just take a String&
instead of a KURL& and pass the url.url() to that, which is what createResource
really wants to be doing anyway (since it only ever uses the String), but is no
less work.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.