[Webkit-unassigned] [Bug 9508] JavaScript Comparing a form element group to itself returns false.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 23 08:08:06 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=9508





------- Comment #6 from darin at apple.com  2007-01-23 08:08 PDT -------
(In reply to comment #3)
> While it certainly would be possible to cache requests for form groups in the
> HTMLFormElement, the issue becomes that if we don't cache every single unique
> request for the life of the HTMLFormElement, then you potentially could have a
> comparison occur much later that fails when it shouldn't.

I don't agree with this comment. There's no problem creating a design where the
collection is registered with the form; the form points to it and when the
collection is destroyed the pointer in the form gets cleared.

We don't need to make any change to the collection lifetime at all to do this
-- we just need to add a pointer to HTMLFormElement and add the code to the
collection class to clear this pointer when the collection is deallocated. I
think this change is simple and practical and probably a better choice than
adding the ability to do equality comparison to the JavaScript binding.

By the way, if we do extend the JavaScript binding in this way, we'll also want
it in the C API.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list