[Webkit-unassigned] [Bug 9508] JavaScript Comparing a form element group to itself returns false.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 23 04:10:00 PST 2007


------- Comment #4 from ddkilzer at webkit.org  2007-01-23 04:09 PDT -------
(From update of attachment 12621)
A couple random comments on this patch.  (Note that I'm not a reviewer, so take
these with the proverbial grain of salt! :)

- Instead of needsDeepEqual(), how about hasDeepEqual() or useDeepEqual()?

- Would it be possible to override operator==() instead?  It would be cleaner
than adding two functions, but operator overloading is not obvious when looking
at source.

- You might consider using the LayoutTests/fast/js/resources/js-test-pre.js,
js-test-post.js and js-test-style.css files in your layout test so you don't
have to reinvent the wheel.  Just use relative paths to include these
resources.  See LayoutTests/fast/js/activation-proto.html for an example of how
to use them.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list