[Webkit-unassigned] [Bug 12311] Implement frame loading for Qt. Clean up FrameLoader a bit

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12311





------- Comment #2 from aroben at apple.com  2007-01-18 23:34 PDT -------
(From update of attachment 12533)
 #include "HTMLFormElement.h"
 #include "HTMLNames.h"
 #include "HTMLObjectElement.h"
+#include "HTMLFrameElement.h"

   #includes should be alphabetical.

+    if (ownerElement->hasTagName(frameTag) ||
ownerElement->hasTagName(iframeTag)) {
+        HTMLFrameElement* o = static_cast<HTMLFrameElement*>(ownerElement);

   I know this isn't new code, but it seems like this cast should really be to
HTMLFrameElementBase, since that's what both HTMLFrameElement and
HTMLIFrameElement derive from. Also, HTMLFrameElement and HTMLIFrameElement are
the only things that can be HTMLFrameOwnerElements, so I'm not sure what value
the if has.

     class ResourceRequest;
     class ResourceResponse;
     class String;
+    class HTMLFrameOwnerElement;
+    class Widget;
+    class IntSize;

   Please alphabetize these forward declarations.

+        virtual Frame *createFrame(const KURL& url, const String& name,
HTMLFrameOwnerElement* ownerElement,
+                                   const String& referrer, bool
allowsScrolling, int marginWidth, int marginHeight) = 0;

   The * should be next to Frame, and the 'ownerElement' parameter name is
unnecessary. (And ditto in WebFrameLoaderClient.h)

+    // stubbed out until the code is moved here from the FrameBridge, and
FrameLoader looses the createFrame() method

    Typo: 'looses' => 'loses'

   I think it would be good for Darin to have a look at this before checking
in.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.