[Webkit-unassigned] [Bug 12260] Windows platform build is not maintained

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12260


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12422|review?(gombi.webkit at gmail.c|review-
               Flag|om)                         |




------- Comment #2 from ap at webkit.org  2007-01-14 01:09 PDT -------
(From update of attachment 12422)
 }
-
 void FrameLoader::submitForm(const FrameLoadRequest& request, Event*)

    There should be blank lines between functions.

-        virtual bool canTakeFocus(FocusDirection) = 0;
-        virtual void takeFocus(FocusDirection) = 0;
+        virtual bool canTakeFocus(WebCore::FocusDirection) = 0;
+        virtual void takeFocus(WebCore::FocusDirection) = 0;

    The whole ChromeClient class declaration is in WebCore namespace, so this
shouldn't be needed (same with ContextMenuClient).

+bool ChromeClientWin::canTakeFocus (WebCore::FocusDirection)

    There should be no space after canTakeFocus.

+    notImplemented();
+       return false;

    The patch has a lot of tabs - please replace them with spaces.

 }

+
+void WebFrameLoaderClient::assignIdentifierToInitialRequest(unsigned long,
WebCore::DocumentLoader*, const WebCore::ResourceRequest&)

    Why did you add this blank line?

    Please include a ChangeLog with the patch.

  r- for the style issues. What are the remaining link errors?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.