[Webkit-unassigned] [Bug 12214] REGRESSION: css image with relative path is not loaded, when both base element and dir attribute in the html tag are present

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12214


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12366|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2007-01-13 07:33 PDT -------
(From update of attachment 12366)
Great fix!

+    if (m_elemSheet)
+        m_elemSheet.get()->setHref(m_baseURL);

No need for the ".get()" herre. It can just be m_elemSheet->setHref().

It looks to me like this will not work if the style sheet has an @import rule
in it. The @import rule will load based on the original style sheet href, not
the updated one.

This needs at least one layout test; maybe two because of the @import rule
issue.

I think it's OK to fix this even without a fix for the @import rule issue.

review-, because of the lack of a test


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.