[Webkit-unassigned] [Bug 11924] WebCore crash on 64-bit code when loading a web page with a table tag

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11924


reddy at pixar.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reddy at pixar.com




------- Comment #4 from reddy at pixar.com  2007-01-12 18:06 PDT -------
Good comments Darin. I've just attached a revised patch, made against the
latest revision, that also add checks to the callers of ensureRows. And I've
included a ChangeLog entry for the fix too (I left the reviewer as NOBODY - I
don't know what your policy is on filling this in before accepting, so left it
as-is).

Does this patch look okay?

In terms of adding a test, I'd be happy to do this, though I don't feel that
this is perhaps necessary in this case. The reason being that any of the
pre-existing WebCoreLayout/tables tests would crash on the current code under a
64-bit build. E.g., I'm guessing that anyone running WebKit built as a 64-bit
app on Leopard would see this. (See the initial description for a trivial
example of HTML content that crashed WebCore before my fix.) 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.