[Webkit-unassigned] [Bug 12201] Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 10 15:59:45 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12201


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12349|review?                     |review-
               Flag|                            |




------- Comment #2 from macdome at opendarwin.org  2007-01-10 15:59 PDT -------
(From update of attachment 12349)
Glad to see this one fixed!

Bleh.  temp and ret are really bad variable names.  We should use something
more descriptive.

This extra multiply is not necessary:
-        return getAspectRatio(viewBox(), viewportRect);
+        ret = getAspectRatio(viewBox(), viewportRect) * ret;

ret should be the identity there.

I'm not 100% sure this is correct.  It probably is, but I'd like to you tell me
more about it over IRC.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list