[Webkit-unassigned] [Bug 12145] Color parsing is too relaxed in strict mode

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12145


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12336|review?                     |review+
               Flag|                            |




------- Comment #6 from darin at apple.com  2007-01-09 14:15 PDT -------
(From update of attachment 12336)
Looks fine, r=me.

+    if (Color::parseHexColor(name, rgb) && !strict)
         return true;

It would be nice to not even parse in the strict case. Just reverse the two
halves of the &&.

+        static RGBA32 parseColor(const String&, bool = false);

Should have the name strict here, since bool along doesn't make it clear what
the parameter is.

+        static bool parseColor(const String&, RGBA32& rgb, bool);

Ditto.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.