[Webkit-unassigned] [Bug 12170] RenderView holds dangling reference to RenderObjects as selection markers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 8 17:44:47 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12170


occupant4 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12320|                            |review?
               Flag|                            |




------- Comment #3 from occupant4 at gmail.com  2007-01-08 17:44 PDT -------
Created an attachment (id=12320)
 --> (http://bugs.webkit.org/attachment.cgi?id=12320&action=view)
proposed patch

enums are signed on Windows, so in this case, m_selectionState = 4 results in
m_selectionState == -4.  This was causing a RenderText object not to be
recognized as selected, so it was deleted without clearing the selection,
resulting in a dangling ref to it.

I was wrong that this applied to Mac as well.  It appears Mac treats enums as
unsigned in this case.  My asserts were firing for other reasons.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list