[Webkit-unassigned] [Bug 9284] Quirksmode (CSS1): Removing inline border styles is impossible

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=9284





------- Comment #7 from darin at apple.com  2007-01-07 21:19 PDT -------
(From update of attachment 12285)
+struct PropertyLonghand
+{

We should put the brace on the line iwth the struct name.

+static HashMap<int, PropertyLonghand* >* shorthandMap;

I don't think the space before the > is needed here. I think the values should
be PropertyLonghand, no need for pointers.

The shortHandMap could be a static inside the
CSSMutableStyleDeclaration::removeProperty function -- I think I like that
slightly better.

It would be nice if the function that turns a propertyID into a pointer to a
list of property IDs and a length was put with the other shorthand handling
rather than right here in CSSMutableStyleDeclaration --
CSSMutableStyleDeclaration could just call a function defined there. That might
make it easier to keep the list of shorthands in sync with the other lists of
shorthands.

Should I mark this review- now, or do you want other people to look at it?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.