[Webkit-unassigned] [Bug 12150] The cases where no stops are defined, or when a stop offset is less than previous not handled correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 7 12:01:17 PST 2007


------- Comment #2 from zimmermann at kde.org  2007-01-07 12:01 PDT -------
Hey Remi,

patch looks great! Two tiny comments:

     m_stops = stops;
-    std::sort(m_stops.begin(), m_stops.end(), compareStopOffset);

you can remove the static compareStopOffset helper completelty.

+        CGFloat currOffset = max(stops[i].first,previousOffset);

missing space between first and previousOffset.

Keep up the good work.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list