[Webkit-unassigned] [Bug 11841] Image with no src doesn't show alt text instead

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 6 17:15:35 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=11841





------- Comment #6 from darin at apple.com  2007-01-06 17:15 PDT -------
(From update of attachment 12232)
+            imageObj->setImageSizeForAltText(NULL);

+                imageObj->setImageSizeForAltText(NULL);

Should be 0 rather than NULL. Might also just be good to have the parameter
default to 0.

Need to indent 4 characters, not 2.

I'd like to see both the 4s and the 1024 and 256 as named constants, even
though they weren't in the old code.

Is there any case where we have to transition from the missing image to a
successful load. If so, then I don't see how the intrinsic width would be
restored.

This otherwise looks great to me.

Not marking as reviewed because I'd like Hyatt to review this one if possible.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list