[Webkit-unassigned] [Bug 10587] pointer-events is not implemented for RenderSVGImage or RenderSVGText

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 6 12:35:32 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=10587





------- Comment #10 from macdome at opendarwin.org  2007-01-06 12:35 PDT -------
(From update of attachment 12258)
-    : RenderObject(node)
+    : RenderObject(node), PointerEventsInterface()

separate line for each constructor

pointerEventsHItRules is yet another reason why it would be nice to have some
sort of SVG base class for all the SVG renderers.

Maybe it makes sense to just have the pointer events logic all in
PointerEventsHitRules (making it a class).  then you'd just do something like:

PointerEventHitRules(kSVGImageRules, style()->svgStyle()->pointerEvents())

It seems sorta odd for RenderPath to inherit from PointerEventsInterface, since
no one ever uses that interface except for internal RenderPath methods.  It's
also not as though the hit rules are bound to any specific type, so much as all
the various element types subscripe to some set of hit rules.  Just a thought.

Overall the patch looks fine.  Lets chat about this briefly over IRC though.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list