[Webkit-unassigned] [Bug 12106] Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 4 21:01:00 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12106


Graham.Dennis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Attachment #12233|                            |review?
               Flag|                            |
         AssignedTo|webkit-                     |Graham.Dennis at gmail.com
                   |unassigned at lists.webkit.org |




------- Comment #1 from Graham.Dennis at gmail.com  2007-01-04 21:01 PDT -------
Created an attachment (id=12233)
 --> (http://bugs.webkit.org/attachment.cgi?id=12233&action=view)
patch 1

Patch 1.
Passes layout tests, but no layout test added, as to test this, you need to be
able to create a WebResourceLoadDelegate.

The problem was that m_request isn't set until the end of
ResourceLoader::willSendRequest(), and so oldURL was always empty. But even if
we replace oldURL with m_originalURL (which is set at the start of
ResourceLoader::load()), the newRequest is only updated if the new and old URLs
are the same. This patch fixes both problems so that WebResourceLoadDelegates
can now change URLs.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list