[Webkit-unassigned] [Bug 9454] CSS2: Language not inherited from parent element

Thu Jan 4 12:25:18 PST 2007

http://bugs.webkit.org/show_bug.cgi?id=9454

rwlbuis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12133|review?                     |review-
               Flag|                            |

------- Comment #7 from rwlbuis at gmail.com  2007-01-04 12:25 PDT -------
(From update of attachment 12133)
>+<html >

No need for the extra space.

>+  p:lang(x) { background:lime }

Please use green here, it is used throughout the layout tests.
The testcase seems fine, be sure to include expected results(.txt,.checksum and
.png). You can get them by running run-webkit-tests and run-webkit-tests -p.

>+                // but the it has not been clarified how lang and xml:lang coexists

You probably didnt mean to write "the" there.

>+                Node *n = e->parent();

* needs to right next to Node (see style guidelines).

>+                    /*
>+                    else
>+                    if (n->isDocumentNode()) {
>+                        value = static_cast<Document*>(n)->contentLanguage();
>+                    */

AFAIK code in comments should not be included in patches. Also the code is not
100% according to style guidelines.

>+2006-12-31  Allan Sandfeld Jensen,,,  <set EMAIL_ADDRESS environment variable>

Make sure this line is correct, you need to give your mail, and I see no need
for the ,,,

So coding wise this patch seems fine (except some style problems mentioned). As
soon as you fix the points above I am fine with r+ing it.

-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.