[Webkit-unassigned] [Bug 11611] REGRESSION: No http referer header sent on XMLHttpRequest

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11611


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12185|                            |review?
               Flag|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-                     |ap at webkit.org
                   |unassigned at lists.webkit.org |




------- Comment #2 from ap at webkit.org  2007-01-03 05:57 PDT -------
Created an attachment (id=12185)
 --> (http://bugs.webkit.org/attachment.cgi?id=12185&action=view)
proposed fix

As of r18544, I could only reproduce this with async requests. One reason was
that String::operator!() is used to check if a referer has been already set,
and the default implementation of this operator doesn't work correctly:

    if (!hideReferrer && !request.httpReferrer())
        newRequest.setHTTPReferrer(fl->outgoingReferrer());

Another reason was that ResourceRequest->NSURLRequest conversion logic was a
bit messed up in SubresourceLoader::create(). I rewrote this method to use
ResourceRequest::nsURLRequest(). One thing I'm not quite sure about is a FIXME
that I removed:

// FIXME: Because of <rdar://problem/4803505>, the method has to be set before
the body.

It was added in r17294 without a test or much explanation, and seems to be
obsolete.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.