[Webkit-unassigned] [Bug 5164] Non-integer percentages are incorrectly rounded down in Safari

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=5164





------- Comment #18 from ddkilzer at webkit.org  2007-01-02 21:47 PDT -------
(From update of attachment 12157)
>Index: WebCore/rendering/AutoTableLayout.cpp
>===================================================================
>--- WebCore/rendering/AutoTableLayout.cpp	(revision 18517)
>+++ WebCore/rendering/AutoTableLayout.cpp	(working copy)
>@@ -86,9 +86,10 @@
>                     }
> 
>                     Length w = cell->styleOrColWidth();
>-                    if (w.value() > 32760)
>-                        w.setValue(32760);
>-                    if (w.value() < 0)
>+                    // FIXME: What is this arbitrary value?
>+                    if (w.rawValue() > 32760)
>+                        w.setRawValue(32760);
>+                    if (w.isNegative())
>                         w.setValue(0);
>                     switch(w.type()) {
>                     case Fixed:

I believe the arbitrary 32760 values represent the maximum number of columns
allowed in a table.  I think it matches up to what FireFox allows, but I don't
remember where I heard about it (in #webkit or in a bug or comment somewhere).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.